Skip to content
This repository was archived by the owner on Jul 10, 2021. It is now read-only.

Conversation

@phebe-vickers
Copy link
Contributor

@phebe-vickers phebe-vickers commented Dec 1, 2020

updated the instructions.

@317brian
Copy link
Contributor

317brian commented Dec 1, 2020

Can you PTAL for the technical side @kevinawoo

@phebe-vickers
Copy link
Contributor Author

Forgot to note that this resolves Issue: #2091
Customer logged issue here and then reached out to Armory Support to find a solution.
This PR is the solution we tested and found.

@kevinawoo kevinawoo changed the title docs(aws): AWS Launch Template only applicable for 1.23 and above, upd… docs(aws): AWS Launch Template only applicable for 1.23 and above Dec 2, 2020
Copy link
Member

@kevinawoo kevinawoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments for the review.

@brian-armory do we have a process for 1.24 to remember to uncomment out these sections?

@kevinawoo kevinawoo merged commit 07fa46c into spinnaker:master Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants